fixed bug：Fix the problem that some types of yaml configuration cannot be converted, resulting in configuration loss #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修复读取ssl配置时 因配置bool值导致配置读取不全的bug go-chassis#122 go-chassis/go-chassis#991
|
感谢，PR的题目需要更加具体些，commit message也是 |
|
另外，修改了这个，需要增加一个UT case来保护功能基线 |
为yaml配置需要转换的类型增加UT 例如 bool -> string
five111
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复yaml配置部分类型无法转换导致配置丢失的问题
比如 yaml配置value为bool类型 而接受类型为stirng 此时会将 bool转成stirng
#122
go-chassis/go-chassis#991