delete event fo moudule events would be ignored #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,6 +123,7 @@ type Event struct { | |||
| EventType string | |||
| Key string | |||
| Value interface{} | |||
| HasUpdated bool | |||
There was a problem hiding this comment.
在manager.go文件的updateEvent方法的最后，会把它置为true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题：当触发配置删除事件时，模块事件通知处理过程中，删除事件会由于该事件已经更新到archaius的缓存从而导致重复更新失败，最终导致该删除事件被忽略。
解决：给事件增加一个标记，标记该事件是否已经被manager更新到缓存里，如果已更新，则直接返回成功，不重复处理