meson.build: add -allinst when compiling with dmd or gdc, #2210
#2219
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoky
reviewed
Nov 17, 2024
meson.build
Outdated
| @@ -9,8 +9,13 @@ compiler = meson.get_compiler('d') | |||
| if compiler.get_id() == 'llvm' | |||
| d_extra_args = ['-vcolumns'] | |||
There was a problem hiding this comment.
The ldc compiler also needs -allinst to be set, or it would throw same error as others (as far as I could test with Arch Linux's ldc)
Suggested change
| d_extra_args = ['-vcolumns'] | |
| d_extra_args = ['-vcolumns', '-allinst'] |
There was a problem hiding this comment.
It makes sense why we would add -allinst to all compilers given it's a frontend bug. I didn't add it for ldc2 since it was the only compiler that was working.
For the record, I tested with ldc2-1.39 and that one worked without the need of -allinst.
This is needed to work around a bug in dmd regarding template emissions. Bug: gnunn1#2210 Bug: https://issues.dlang.org/show_bug.cgi?id=20668 Signed-off-by: Andrei Horodniceanu <[email protected]>
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to work around a bug in dmd regarding template emissions.
Bug: #2210
Bug: https://issues.dlang.org/show_bug.cgi?id=20668