Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add r/demo/users #24

Merged
merged 3 commits into from
Jul 22, 2024
Merged

feat: add r/demo/users #24

merged 3 commits into from
Jul 22, 2024

Conversation

DIGIX666
Copy link
Contributor

Hi @leohhhn ,

I added r/demo/users to p/memeland.

I was able to test it locally, but I wanted to do it with the Adena version as well. However, I couldn't find a way to have my Adena public key in my gnokey list, and from what I found, I believe it's not possible.
I just need to do a unit test on it to be complete. If you could review it when you have time, that would be great. Thank you!

SCR-20240625-pkhc SCR-20240625-pkpn SCR-20240625-pksb SCR-20240625-pleu

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for gno-memeland canceled.

Name Link
🔨 Latest commit b3b1e12
🔍 Latest deploy log https://app.netlify.com/sites/gno-memeland/deploys/669df5a30e859c0008e49dfa

@leohhhn
Copy link
Collaborator

leohhhn commented Jul 18, 2024

Hey, can you change the panic to be more descriptive? Something like "you need to register in r/demo/users to be able to post" - or similar.

@leohhhn leohhhn mentioned this pull request Jul 18, 2024
@DIGIX666
Copy link
Contributor Author

Hey, can you change the panic to be more descriptive? Something like "you need to register in r/demo/users to be able to post" - or similar.

For sure, this is a new panic message bfaa99f

@leohhhn leohhhn self-requested a review July 22, 2024 05:59
Copy link
Collaborator

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, just suggested a better panic message :)

api/p/memeland/memeland.gno Outdated Show resolved Hide resolved
@leohhhn leohhhn merged commit 7aaffc8 into gnoverse:main Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants