feat: ListUsersByPrefix and ListJsonUsersByPrefix #35
Conversation
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
| // (The caller usually has already called usernameOf to get the username, but if | ||
| // it is "" then this will get it.) |
There was a problem hiding this comment.
Don't understand this comment :)
There was a problem hiding this comment.
This function has an argument for the user address, but also an argument for the username. We want to save CPU cycles. In all the cases where code needs to call this function, it has already looked up the user name by user address.
https://github.com/gnolang/gnosocial/blob/1c86452df7b8f9400863386b98edeaa3c7c12aa9/realm/public.gno#L70
So it should not be necessary for this function to look it up again. The comment is justifying why this function has a username argument. For completeness, this function will look up the username by user address, but only if the caller doesn't provide the username.
There was a problem hiding this comment.
Do you think that the comment needs to be updated?
jefft0
changed the title
The GnoSocial demo app needs to search by username. This PR has three commits:
gUserAddressByName. Add a centralized utility functiongetOrCreateUserPostswhich creates a new UserPosts if needed and adds it togUserPostsByAddressas well as updatinggUserAddressByName. Change public functions likePostMessageto usegetOrCreateUserPosts. Also, we can simplifyRenderfor the main page by listing all usernames directly fromgUserAddressByName.ListUsersByPrefix. (This uses a temporary local copy ofListKeysByPrefixwhich can be removed when the PR is merged to add this to p/demo/avlhelpers.) Also, addListJsonUsersByPrefixwhich returns the same result a JSON array.GetUsersandGetJsonUsers(which return all users and are not scalable). The app can useListJsonUsersByPrefixinstead.