Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1025 fix: overflow router ratio calculation #210

Merged
merged 1 commit into from
Apr 16, 2024
Merged

GSW-1025 fix: overflow router ratio calculation #210

merged 1 commit into from
Apr 16, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Apr 16, 2024

Fix

  1. depends on pool's current tick, calculation may results overflow

@r3v4s r3v4s requested review from notJoon and mconcat April 16, 2024 06:48
@r3v4s r3v4s self-assigned this Apr 16, 2024
@notJoon notJoon merged commit 681a137 into main Apr 16, 2024
1 check passed
@notJoon notJoon deleted the GSW-1025-fix-overflow-router-swap-ratio-calculation branch April 16, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@mconcat mconcat Awaiting requested review from mconcat

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v4s @notJoon