Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat [GSW-1676] Launchpad i18n #549

Merged
merged 18 commits into from
Oct 31, 2024
Merged

Feat [GSW-1676] Launchpad i18n #549

merged 18 commits into from
Oct 31, 2024

Conversation

tfrg
Copy link
Collaborator

@tfrg tfrg commented Oct 30, 2024

Feature

Launchpad page i18n

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 9:33am

onlyhyde
onlyhyde previously approved these changes Oct 31, 2024
Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I left a few small comments.

- Removed direct dependency on i18n instance.
- Made formatTime a pure function by passing the formatting function as an argument.
- Updated getStatusText to follow the same pattern.
jinoosss
jinoosss previously approved these changes Oct 31, 2024
jinoosss
jinoosss previously approved these changes Oct 31, 2024
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
19.8% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@tfrg tfrg merged commit b9e3986 into develop Oct 31, 2024
5 of 6 checks passed
@tfrg tfrg deleted the GSW-1676-launchpad-i18n branch October 31, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants