-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [GSW-1676] Launchpad i18n #549
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.../web/src/components/common/launchpad-modal/launchpad-deposit-modal/LaunchpadDepositModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I left a few small comments.
...chpad-my-participation/launchpad-my-participation-no-data/LaunchpadMyParticipationNoData.tsx
Outdated
Show resolved
Hide resolved
...c/views/launchpad/launchpad-detail/components/launchpad-participate/LaunchpadParticipate.tsx
Outdated
Show resolved
Hide resolved
...c/views/launchpad/launchpad-detail/components/launchpad-participate/LaunchpadParticipate.tsx
Outdated
Show resolved
Hide resolved
.../launchpad/launchpad-detail/components/launchpad-project-summary/LaunchpadProjectSummary.tsx
Outdated
Show resolved
Hide resolved
- Removed direct dependency on i18n instance. - Made formatTime a pure function by passing the formatting function as an argument. - Updated getStatusText to follow the same pattern.
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Feature
Launchpad page i18n