Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark implementation contract initialized on deploy #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jfschwarz
Copy link
Contributor

No description provided.

@jfschwarz jfschwarz changed the title Mark initialized Mark implementation contract initialized on deploy Feb 1, 2022
@auryn-macmillan
Copy link
Contributor

Rather than adding initializer to a constructor, we should have the constructor call initialize. This way users can choose to deploy this as a proxy or the full contract.

e.g.

constructor (address _owner,
    address _token,
    uint256 _depositDeadline,
    uint256 _lockDuration,
    string memory _name,
    string memory _symbol) {
  initialize(
    _owner,
    _token,
    _depositDeadline,
    _lockDuration,
    _name,
    _symbol
  );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants