Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if question is invalid before looking for replicated answer #530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check if question is invalid before looking for replicated answer #530

wants to merge 1 commit into from

Conversation

kongzii
Copy link
Contributor

@kongzii kongzii commented Oct 23, 2024

No description provided.

kongzii
kongzii commented Oct 23, 2024
View reviewed changes
prediction_market_agent/agents/replicate_to_omen_agent/omen_resolve_replicated.py
m,
(
find_resolution_on_other_markets(m)
if not is_invalid(m.question_title)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that if the invalid market is already replicated, but then we fix is_invalid function, we can at least resolve it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evangriffiths evangriffiths evangriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kongzii @evangriffiths