Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade coverage tool #68

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Upgrade coverage tool #68

merged 2 commits into from
Jan 5, 2018

Conversation

cag
Copy link
Contributor

@cag cag commented Nov 22, 2017

Changeset is because solidity-coverage has the following breaking change:

Important: v0.4.0 targets solidity >= pragma 0.4.18 and introduces a breaking change for projects that rely on Truffle's simplified contract method interface. All constant view or pure methods now need to be explicitly invoked using .call. e.g:

@codecov-io
Copy link

Codecov Report

Merging #68 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage    91.5%   91.68%   +0.18%     
==========================================
  Files          27       27              
  Lines         671      758      +87     
  Branches      111      111              
==========================================
+ Hits          614      695      +81     
- Misses         57       63       +6
Impacted Files Coverage Δ
contracts/Events/CategoricalEvent.sol 70% <0%> (-7.78%) ⬇️
contracts/Tokens/StandardToken.sol 71.42% <0%> (-4.58%) ⬇️
contracts/Events/ScalarEvent.sol 79.16% <0%> (-3.45%) ⬇️
contracts/Oracles/DifficultyOracle.sol 61.53% <0%> (-2.1%) ⬇️
contracts/Events/Event.sol 100% <0%> (ø) ⬆️
contracts/Oracles/FutarchyOracle.sol 100% <0%> (ø) ⬆️
contracts/Markets/StandardMarket.sol 100% <0%> (ø) ⬆️
contracts/Oracles/MajorityOracle.sol 100% <0%> (ø) ⬆️
contracts/Oracles/SignedMessageOracle.sol 0% <0%> (ø) ⬆️
contracts/Oracles/UltimateOracle.sol 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc8458...9e260ee. Read the comment docs.

@cag cag merged commit 362a2f3 into master Jan 5, 2018
@cag cag deleted the upgrade-coverage-tool branch September 25, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants