Update to Solidity v0.5 and Truffle v5.0 - 'v1' branch #170
Conversation
- Update to Truffle v5.0.9
- Update .sol files for the breaking changes of Solidity v0.5
- Explicitly configure Truffle to use solc v0.5.6
(because some updated dependencies require solc version above the current default v0.5.0 version that came with current Truffle version)
- Add solc v0.5.6 to package.json
- Add compiler configuration to truffle.js
- Update js test files to work with Web3 v1.0.
Updates are mainly:
- Use BigNumber.js and `.toString()` instead of `.valueOf()` because of issues with BN.js: web3/web3.js#2171
- Use async / await with Web3 because all Web3 v1.0 calls are asynchronous
- Update Open Zeppelin to v2.2.0 and Canonical WEth to v1.4
- Configure Travis to use Node 10 and 9 (Truffle v5 does not work with Node 7)
|
I found planning to do the transition to Solidity 0.5. And I hope to participate in this. This pull request should also resolve the error raised when executing |
|
Hello @InfiniteStyles, |
|
Hi @InfiniteStyles |
|
Hey, I'll take a closer look at this myself at some point. @InfiniteStyles isn't maintaining this repo anymore. |
There was a problem hiding this comment.
Hey, this is quite a huge changeset, but it all looks good to me. I do appreciate the drudge work done here. Internally, our focus has shifted elsewhere, so thanks for this maintenance work. I have one nitpick, if you don't mind, and I'll probably have to release this as a major version update, since even though nothing on the contract interface level has changed, I would guess that most of the dependencies might be using legacy toolchains which would break with this update.
| assert( | ||
| isClose(actual, expected), | ||
| isClose(actual, expected, relTol=1e-3, absTol=1e-9), |
There was a problem hiding this comment.
I think this will actually create relTol and absTol as global variables and set them to those values. I believe what you actually want to do is just:
isClose(actual, expected, 1e-3, 1e-9)I do like that feature from Python though ;)
There was a problem hiding this comment.
Thanks for your appreciation.
I updated the code accordingly.
Regarding the version, do you like me to update the version at package.json to be 1.3.0? Anything else do I have to change regarding?
Many thanks
There was a problem hiding this comment.
No, I can take care of the versioning later. Thanks!
(because some updated dependencies require solc version above the current default v0.5.0 version that came with current Truffle version)
Updates are mainly:
- Use BigNumber.js and
.toString()instead of.valueOf()because of issues with BN.js: Concern over bn.js dependency in 1.0 web3/web3.js#2171- Use async / await with Web3 because all Web3 v1.0 calls are asynchronous