Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Added TypedDataV3Signer #686

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Added TypedDataV3Signer #686

merged 1 commit into from
Jun 10, 2021

Conversation

nlordell
Copy link
Contributor

@nlordell nlordell commented Jun 10, 2021

This PR just forward ports #659 onto main:

Closes (supersedes) #650

As per comment on that PR (#650 (comment)), this change introduces a Signer class that uses eth_signTypedData_v3 instead of eth_signTypedData_v4 on the method signTypedData

Test Plan

Tested via yalc on gnosis/cowswap#576 with TrustWallet

* Added TypedDataV3Signer

* New helper function to check whether provider isJsonRpcProvider

* Refactored TypedDataV3Signer to fail early when provider is not set

Co-authored-by: Leandro Boscariol <[email protected]>
@nlordell nlordell added the trivial Quick and easy to review label Jun 10, 2021
@nlordell nlordell added the merge when green Merge when green! label Jun 10, 2021
@mergify mergify bot merged commit 7fd36ca into main Jun 10, 2021
@mergify mergify bot deleted the cherry-pick-signer-fix branch June 10, 2021 07:32
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge when green Merge when green! trivial Quick and easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants