This repository has been archived by the owner on Feb 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Feature/adding priv key wallet #384
Open
W3stside
wants to merge
16
commits into
develop
Choose a base branch
from
feature/Adding-PrivKey-Wallet
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR deployments
* create selector to look for tokens in tokenList * add WETH template, sans address * make swapTokensInAPair aware of the current WETH token * use new and improved swapTokensInAPair in reducer * add title display on symbol hover in TokenItem
passed into integrations/provider
Travis automatic deployment: |
1 similar comment
Travis automatic deployment: |
Travis automatic deployment: |
1 similar comment
Travis automatic deployment: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private Key Wallet round 1... Fight!
localhost
as it is hard-coded in - TODO: allow user to enter URL of infura node to connect to?boolean
parameter on setup. This does present problems as changing wallets and clicking the same will always re-instantiate things. But this works and prevents reloading of API during setup.validateTransaction
modal like MM does before signing. It sucks because, well it sucks, and mainly because it covers the informative modals telling users what's going on. Need to find a better solution.