fix(storage): Refactor improving performance and atomicity. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview: This commit overhauls the Storage layer to set the foundation for a high-performance filtering system based on bitmap indexing. The refactoring introduces a more efficient data handling model and resolves critical issues that affected stability and performance. Key Changes: - Introduced the concept of 'WriteBatch' in the Storage interface to support efficient data operations. - Removed the DB interface to eliminate excessive abstraction, making difficult the implementation of database-specific optimizations. - Fixed the handling of byte arrays in Pebble's closer method to prevent data corruption. The Storage layer now ensures that data is parsed correctly before the Get operation is closed, eliminating the risk of random failures. - Implemented batching for data writting from remote nodes, enhancing data consistency and speed. - Restructured Mock objects into an internal package, restricting access to internals and eliminating the need for specific build tags. Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
zivkovicmilos
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Looks great 💯
Thank you for adding these improvements 🙏
I've ran this on the test3 testnet, which at the moment had ~252 250 blocks. It synced and indexed the entire chain in ~3min:
2024-02-08T11:47:53.430+0100 # start
2024-02-08T11:50:50.378+0100 # endJust to give perspective, it used to take ~30min to sync the entire chain (less blocks than this) before this PR, so a x10 improvement 👏
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This commit overhauls the Storage layer to set the foundation for a high-performance filtering system based on bitmap indexing. The refactoring introduces a more efficient data handling model and resolves critical issues that affect stability and performance.
Key Changes: