feat: Add ordering on new filtered methods. #106
+465
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Navarro <[email protected]>
Signed-off-by: Antonio Navarro <[email protected]>
Signed-off-by: Antonio Navarro <[email protected]>
Signed-off-by: Antonio Navarro <[email protected]>
Signed-off-by: Antonio Navarro <[email protected]>
ajnavarro
commented
Oct 29, 2024
| return false | ||
| } | ||
|
|
||
| // TODO check if this is correct |
zivkovicmilos
approved these changes
Nov 7, 2024
| @@ -51,7 +51,6 @@ linters: | |||
| - tagliatelle # Checks struct tags | |||
| - tenv # Detects using os.Setenv instead of t.Setenv | |||
| - testableexamples # Checks if examples are testable (have expected output) | |||
| - unparam # Finds unused params | |||
| @@ -66,6 +66,19 @@ func (m *Storage) TxIterator( | |||
| panic("not implemented") // TODO: Implement | |||
| } | |||
|
|
|||
| func (m *Storage) BlockReverseIterator(_, _ uint64) (storage.Iterator[*types.Block], error) { | |||
| panic("not implemented") // TODO: Implement | |||
| _, | ||
| _ uint32, | ||
| ) (storage.Iterator[*types.TxResult], error) { | ||
| panic("not implemented") // TODO: Implement |
Comment on lines
+139
to
+140
| var err error | ||
| var it storage.Iterator[*bfttypes.Block] |
There was a problem hiding this comment.
Lil' nitpick:
var (
err error
it storage.Iterator[*bfttypes.Block]
)| return false | ||
| } | ||
|
|
||
| // TODO check if this is correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new field apart from
whereto make it possible to change the output ordering for new filtered methods.