Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add engineering section #14

Merged
merged 24 commits into from
Aug 2, 2023
Merged

Conversation

zivkovicmilos
Copy link
Member

Description

This PR populates the engineering section for gno.land

@zivkovicmilos zivkovicmilos self-assigned this Jul 31, 2023
@zivkovicmilos
Copy link
Member Author

zivkovicmilos commented Jul 31, 2023

@ajnavarro
Not sure why the CI is failing

EDIT: Seems to be checking that the benchmark website is down for some reason, not an issue

docs/engineering/gno.land/resources.md Outdated Show resolved Hide resolved
docs/engineering/gno.land/setup.md Outdated Show resolved Hide resolved
docs/engineering/gno.land/team.md Outdated Show resolved Hide resolved
docs/engineering/gno.land/tools.md Outdated Show resolved Hide resolved
docs/engineering/teams/metodology.md Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
docs/engineering/conventions/conventions.md Show resolved Hide resolved
@ajnavarro
Copy link
Collaborator

EDIT: Seems to be checking that the benchmark website is down for some reason, not an issue

It is down because the custom action runner is not deployed yet, so the benchmark workflow is not being executed.

@moul
Copy link
Member

moul commented Aug 1, 2023

Hey team, I just added a new file and asked Guilhem to review the changes on this working branch.

PR Link: Link

I recommend merging this PR once it's in good shape, so we can iterate and refine the details as needed.

Feel free to keep PR concise instead of going into too much detail. Let's keep the momentum going!

@moul moul requested a review from gfanton August 1, 2023 08:06
Copy link
Collaborator

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should comment benchmarks link until it is rendering results to avoid the CI error on future PRs. Apart from that, LGTM.

@zivkovicmilos
Copy link
Member Author

Maybe we should comment benchmarks link until it is rendering results to avoid the CI error on future PRs. Apart from that, LGTM.

I temporarily removed the link:
cd6ad99

Will open up an issue for it so we don't forget

@zivkovicmilos
Copy link
Member Author

@moul

Do you want us to merge this out, or do you want us to wait for @gfanton to give a look?

I want to get Alexis' eyes on this so he can help tighten the color palette / design of the docs before we go live

@gfanton
Copy link
Member

gfanton commented Aug 1, 2023

@zivkovicmilos This guide looks really cool and comprehensive. However, one point I find a little confusing is when I reached the meeting section. I was confused to see that in gno.land; I may be wrong, but I would personally prefer to have this in a separate section along with Team.

@zivkovicmilos
Copy link
Member Author

@zivkovicmilos This guide looks really cool and comprehensive. However, one point I find a little confusing is when I reached the meeting section. I was confused to see that in gno.land; I may be wrong, but I would personally prefer to have this in a separate section along with Team.

@gfanton
I love the idea, and have moved the Meetings section to be under Team:
320f5e0

@moul
Copy link
Member

moul commented Aug 1, 2023

@zivkovicmilos: Do you want us to merge this out, or do you want us to wait for @gfanton to give a look?

Since the repo is new, I propose focusing on either structure-oriented PRs or content-oriented PRs. Structure takes precedence, and we can allocate more time for content discussions.

As long as we avoid merging anything significantly flawed, I recommend merging once the improvements are in place and reviewed.|

@moul
Copy link
Member

moul commented Aug 1, 2023

For meetings, maybe we can just link to https://github.com/gnolang/meetings for a single source of truth.

@zivkovicmilos
Copy link
Member Author

@moul

I've updated the doc to point to our meetings repository. I'll open up a PR on that repo to spruce up the README a bit
04fda52

@zivkovicmilos
Copy link
Member Author

@moul

Merging this out now as all comments seem resolved.
We need this PR merged out to proceed with fine tuning the guide

@zivkovicmilos zivkovicmilos merged commit 6b3a262 into main Aug 2, 2023
@zivkovicmilos zivkovicmilos deleted the feature/add-engineering-section branch August 2, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants