-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add engineering section #14
Conversation
@ajnavarro EDIT: Seems to be checking that the benchmark website is down for some reason, not an issue |
It is down because the custom action runner is not deployed yet, so the benchmark workflow is not being executed. |
Hey team, I just added a new file and asked Guilhem to review the changes on this working branch. PR Link: Link I recommend merging this PR once it's in good shape, so we can iterate and refine the details as needed. Feel free to keep PR concise instead of going into too much detail. Let's keep the momentum going! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should comment benchmarks link until it is rendering results to avoid the CI error on future PRs. Apart from that, LGTM.
I temporarily removed the link: Will open up an issue for it so we don't forget |
@zivkovicmilos This guide looks really cool and comprehensive. However, one point I find a little confusing is when I reached the meeting section. I was confused to see that in |
@gfanton |
Since the repo is new, I propose focusing on either structure-oriented PRs or content-oriented PRs. Structure takes precedence, and we can allocate more time for content discussions. As long as we avoid merging anything significantly flawed, I recommend merging once the improvements are in place and reviewed.| |
For meetings, maybe we can just link to https://github.com/gnolang/meetings for a single source of truth. |
Merging this out now as all comments seem resolved. |
Description
This PR populates the engineering section for
gno.land