chore: In gnoNativeService, support using the remote Gnokey Mobile service #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <[email protected]>
…ent. Add getClient() and use it in QueryAccount, etc. See the PR. Signed-off-by: Jeff Thompson <[email protected]>
…remote service. Signed-off-by: Jeff Thompson <[email protected]>
…ey Mobile service to sign the tx. See the PR. Signed-off-by: Jeff Thompson <[email protected]>
jefft0
force-pushed
the
chore/gnoNativeService-support-useGnokeyMobile
branch
from
57b3f96
to
c2c7283
Compare
…t in GnoNativeApi initClient to call startGnokeyMobileService(). Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR gnolang/gnokey-mobile#2 creates the Gnokey Mobile service. This PR updates
GnoNativeServicewith the option to use the remote Gnokey Mobile service as needed (for example, to sign a transaction).UseGnokeyMobile.initService, ifUseGnokeyMobilethen setgnokeyMobileClientto a gRPC client connected to the remote Gnokey Mobile service. Setclientto a gnoclient without a Keybase (because the purpose is to use Keybase in the remote Gnokey Mobile service).gnoNativeService, addgetClientwhich returns the correctgnoclient.Client. If notuseGnokeyMobilethen simply returns.client. IfuseGnokeyMobilethen it's possible that Gnokey Mobile has been changed to use a different gno.land remote, so we must call the Gnokey Mobile methodGetRemote. If this is different from our locals.remotethen reconfigure theRPCClientof the gnoclient and save the news.remote. ChangeQueryAccount,Query,RenderandQEvalto callgetClientand then proceed as normal. This means that if an app is using Gno Native Kit withUseGnokeyMobile, then the app can send these queries directly to the gno.land remote node, but we must make sure that it is the correct remote.GetRemoteandListKeyInfo, ifuseGnokeyMobilethen we directly use the Gnokey Mobile service.Call, ifuseGnokeyMobilethen use the localMakeCallTxto make the transaction. Use theSignTxAPI of the remote Gnokey Mobile service to sign the transaction. Then use the localBroadcastTxCommitto broadcast the signed transaction and get the streaming result.The above changes allow an app to configure its Gno Native Kit to use a gRPC client with the Gnokey Mobile service. But we still need the Gnokey Mobile app to start the Gnokey Mobile gRPC server. The following changes allow the Gnokey Mobile app to set
start_gnokey_mobile_servicein the configuration for itsGnoNativeProvider.Bridge, addStartGnokeyMobileService. See the description comment. Add this method to the TypeScriptGoBridgeInterfaceand to the Java and SwiftGnonativeModule.Config, add a flagstart_gnokey_mobile_service. Check this flag in theGnoNativeApiinitClientand callstartGnokeyMobileService().