WIP feat: improve grc20/foo20 APIs #952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manfred Touron <[email protected]>
Signed-off-by: Manfred Touron <[email protected]>
Signed-off-by: Manfred Touron <[email protected]>
moul
changed the title
10 tasks
albttx
reviewed
Sep 4, 2023
| // expose a safe instance to the endusers. | ||
| type AdminToken struct { | ||
| type Banker20 struct { |
There was a problem hiding this comment.
NOTE: Banker20 should have a caller variable (set to nil by default) for example which when you call GRC20() that return a IGRC20. force to use the caller variable.
This fix when you call from a realm the external method, or the internal method when you get the struct
myfoo20 := foo20.SafeGRC20()
myfoo20.Transfer() // <-- std.PrevRealm could lead to error
18 tasks
Draft
|
Closed in favor of #2551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: from a live discussion when reviewing #938.
Goals:
Checklists...
Contributors Checklist
BREAKING CHANGE: xxxmessage was included in the descriptionMaintainers Checklist
CONTRIBUTING.mdBREAKING CHANGE:in the body)