Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add p/demo/uassert & p/demo/urequire #928

Merged
merged 17 commits into from
Jul 2, 2024

Conversation

moul
Copy link
Member

@moul moul commented Jun 22, 2023

Addresses #923
Addresses #777

Signed-off-by: Manfred Touron <[email protected]>
@moul moul self-assigned this Jun 22, 2023
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 22, 2023
@moul moul changed the title feat: add p/demo/utestify WIP feat: add p/demo/utestify Jun 22, 2023
@moul moul changed the title WIP feat: add p/demo/utestify WIP feat: add p/demo/uassert Jun 23, 2023
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023
@moul moul mentioned this pull request Jun 18, 2024
7 tasks
@moul moul changed the title WIP feat: add p/demo/uassert feat: add p/demo/uassert Jul 2, 2024
Signed-off-by: moul <[email protected]>
@moul moul changed the title feat: add p/demo/uassert feat: add p/demo/uassert & p/demo/urequire Jul 2, 2024
@moul moul marked this pull request as ready for review July 2, 2024 00:38
@moul moul requested review from a team as code owners July 2, 2024 00:38
@moul moul requested review from zivkovicmilos and petar-dambovaliev and removed request for a team July 2, 2024 00:38
Signed-off-by: moul <[email protected]>
@moul moul mentioned this pull request Jul 2, 2024
7 tasks
Signed-off-by: moul <[email protected]>
@moul moul requested a review from leohhhn as a code owner July 2, 2024 01:10
moul added 2 commits July 2, 2024 09:04
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing some minor comments

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need this in my life. One step closer to making gno usable on the day-to-day

examples/gno.land/p/demo/uassert/uassert.gno Show resolved Hide resolved
examples/gno.land/p/demo/uassert/uassert_test.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/uassert/uassert.gno Outdated Show resolved Hide resolved
moul added 2 commits July 2, 2024 14:27
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@zivkovicmilos zivkovicmilos merged commit 326dae7 into gnolang:master Jul 2, 2024
8 checks passed
@zivkovicmilos zivkovicmilos mentioned this pull request Jul 2, 2024
7 tasks
zivkovicmilos added a commit that referenced this pull request Jul 2, 2024
## Description

This PR includes a hotfix for the `urequire` gno.mod to have a proper
module path, introduced in #928

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
Addresses gnolang#923 
Addresses gnolang#777

---------

Signed-off-by: Manfred Touron <[email protected]>
Signed-off-by: moul <[email protected]>
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
## Description

This PR includes a hotfix for the `urequire` gno.mod to have a proper
module path, introduced in gnolang#928

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Status: 🌟 Wanted for Launch
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants