fix(pkg/errors): correct stacktraces for inlined functions #901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugs found after hunting down other bugs in #859...
see before vs after stacktrace,
make _test.gnolang.stdlibs
on a function which callspanic()
in gno codeNote that the new stacktrace adds the call to uverse.go and op_call.go, absent in the old one. This helps make sense of the stacktrace, which otherwise jumps to places that don't make sense in context. Ie.
The changes respect what godoc says about using runtime.Callers: