Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add r/gnoland/pages #874

Merged
merged 11 commits into from
Jul 29, 2023
Merged

feat: add r/gnoland/pages #874

merged 11 commits into from
Jul 29, 2023

Conversation

moul
Copy link
Member

@moul moul commented Jun 7, 2023

This PR adds a new r/gnoland/pages realm, powered by the p/demo/blog engine.
It's intended to be used the same way, but only contain pages which will be updated more frequently.

The first pages will be:

  • r/gnoland/pages:p/gor
  • r/gnoland/pages:p/events
  • r/gnoland/pages:p/tokenomics
  • r/gnoland/pages:p/start

And will allow making gno.land even simpler, and just linking to these dynamic onchain pages.

Deploy depends on #362 (test4) due to mismatched avl versions on test3.

Contributors Checklist

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

Maintainers Checklist

  • Checked that the author followed the guidelines in CONTRIBUTING.md
  • Checked the conventional-commit (especially PR title and verb, presence of BREAKING CHANGE: in the body)
  • Ensured that this PR is not a significant change or confirmed that the review/consideration process was appropriate for the change

Signed-off-by: Manfred Touron <[email protected]>
@moul moul self-assigned this Jun 7, 2023
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 7, 2023
@moul moul mentioned this pull request Jun 7, 2023
16 tasks
moul added 2 commits June 7, 2023 17:25
Signed-off-by: Manfred Touron <[email protected]>
Signed-off-by: Manfred Touron <[email protected]>
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 7, 2023
moul added 2 commits June 7, 2023 18:01
Signed-off-by: Manfred Touron <[email protected]>
Signed-off-by: Manfred Touron <[email protected]>
@moul moul marked this pull request as ready for review June 7, 2023 09:44
@moul moul requested a review from a team as a code owner June 7, 2023 09:44
@github-actions github-actions bot removed the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 20, 2023
)

func init() {
// adminAddr = std.GetOrigCaller() // FIXME: find a way to use this from the main's genesis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we open an issue for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check, I think we already have one, it’s related to the thing we said about having a way to skip the need of faucet for local development, where we could imagine having a detection of accounts on the FS to automatically craft a genesis.

Note that we already have a system which patches the genesis to have a dynamic hostname.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we set this value in the init method (constructor)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but not with « auto-genesis »; we need to have the auto-genesis taking an account as argument to simulate the initial uploaded.

examples/gno.land/r/gnoland/pages/admin.gno Outdated Show resolved Hide resolved
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@zivkovicmilos
Copy link
Member

@moul
The example test seems to be failing:
Screenshot 2023-07-27 at 18 46 41

@moul moul merged commit bdb1b02 into gnolang:master Jul 29, 2023
@moul moul deleted the dev/moul/addpages branch July 29, 2023 13:00
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
@moul moul added this to the 🚀 main.gno.land (required) milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants