feat(gnovm): improved native bindings

.gitattributes

@@ -1,3 +1,5 @@
 *.gno linguist-language=Go
 *.pb.go linguist-generated merge=ours -diff
 go.sum linguist-generated text
+gnovm/stdlibs/native.go linguist-generated
+gnovm/tests/stdlibs/native.go linguist-generated

.github/codecov.yml

@@ -28,3 +28,7 @@ flags:
     paths:
       - gno.land
     after_n_builds: 3
+  misc:
+    paths:
+      - misc
+    after_n_builds: 1

.github/workflows/lint.yml

@@ -0,0 +1,97 @@
+name: lint
+
+on:
+  push:
+    branches: [ "master" ]
+  pull_request:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Install Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: 1.20.x
+
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          # sync with misc/devdeps/go.mod
+          version: v1.53
+          args:
+            --config=./.github/golangci.yml
+  fmt:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Install Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: 1.20.x
+
+      - name: Install make
+        run: sudo apt-get install -y make
+
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      # prefill dependencies so that mod messages don't show up in make output
+      - name: Fetch dependencies
+        run: go mod download -modfile ./misc/devdeps/go.mod -x
+
+      # inspired by:
+      # https://github.com/Jerome1337/gofmt-action/blob/d5eabd189843f1d568286a54578159978b7c0fb1/entrypoint.sh
+      - name: Check gofumpt
+        run: |
+          output="$(GOFMT_FLAGS=-l make -s fmt)"
+          if [ ! -z "$output" ]; then
+            echo "The following files are not properly formatted; run 'make fmt' to format them."
+            echo "$output"
+            exit 1
+          else
+            echo 'Succeeded.'
+          fi
+  modtidy:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Install Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: 1.20.x
+
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Check go.mods
+        run: |
+          sums="$(sha256sum go.mod misc/devdeps/go.mod)"
+          for path in . ./misc/devdeps; do
+            env -C $path go mod tidy -v || exit 1
+          done
+          echo "$sums" | sha256sum -c
+  generated:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Install Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: 1.20.x
+
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Check generated files are up to date
+        run: |
+          go generate -x ./...
+          if [ "$(git status -s)" != "" ]; then
+            echo "command 'go generate' creates file that differ from git tree, please run 'go generate' and commit:"
+            git status -s
+            exit 1
+          fi

.github/workflows/misc.yml

@@ -1,78 +1,66 @@
+# tests the "misc" directory & tools
+# (not meant for miscellaneous workflows)
 name: misc
 
 on:
+  pull_request:
+    paths:
+      - "misc/genstd/**.go"
+      - "misc/Makefile"
+      - ".github/workflows/misc.yml"
   push:
     branches: [ "master" ]
-  pull_request:
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
   cancel-in-progress: true
 
 jobs:
-  lint:
+  build:
+    strategy:
+      fail-fast: false
+      matrix:
+        go-version: # two latest versions
+          - "1.19.x"
+          - "1.20.x"
+        program:
+          - "genstd"
     runs-on: ubuntu-latest
+    timeout-minutes: 5
     steps:
-      - name: Install Go
-        uses: actions/setup-go@v4
+      - uses: actions/setup-go@v4
         with:
-          go-version: 1.20.x
+          go-version: ${{ matrix.go-version }}
+      - uses: actions/checkout@v3
+      - name: go install
+        working-directory: misc
+        run: go install ./${{ matrix.program }}
 
-      - name: Checkout code
-        uses: actions/checkout@v3
-
-      - name: Lint
-        uses: golangci/golangci-lint-action@v3
-        with:
-          # sync with misc/devdeps/go.mod
-          version: v1.53
-          args:
-            --config=./.github/golangci.yml
-  fmt:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        go-version: [ "1.19.x", "1.20.x" ]
+        args:
+          - _test.genstd
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     steps:
-      - name: Install Go
-        uses: actions/setup-go@v4
+      - uses: actions/setup-go@v4
         with:
-          go-version: 1.20.x
-
-      - name: Install make
-        run: sudo apt-get install -y make
-
-      - name: Checkout code
-        uses: actions/checkout@v3
-
-      # prefill dependencies so that mod messages don't show up in make output
-      - name: Fetch dependencies
-        run: go mod download -modfile ./misc/devdeps/go.mod -x
-
-      # inspired by:
-      # https://github.com/Jerome1337/gofmt-action/blob/d5eabd189843f1d568286a54578159978b7c0fb1/entrypoint.sh
-      - name: Check gofumpt
+          go-version: ${{ matrix.go-version }}
+      - uses: actions/checkout@v3
+      - name: test
+        working-directory: misc
         run: |
-          output="$(GOFMT_FLAGS=-l make -s fmt)"
-          if [ ! -z "$output" ]; then
-            echo "The following files are not properly formatted; run 'make fmt' to format them."
-            echo "$output"
-            exit 1
-          else
-            echo 'Succeeded.'
-          fi
-  modtidy:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Install Go
-        uses: actions/setup-go@v4
+          export GOPATH=$HOME/go
+          export GOTEST_FLAGS="-v -p 1 -timeout=30m -coverprofile=coverage.out -covermode=atomic"
+          make ${{ matrix.args }}
+      - if: runner.os == 'Linux'
+        uses: codecov/codecov-action@v3
         with:
-          go-version: 1.20.x
-
-      - name: Checkout code
-        uses: actions/checkout@v3
-
-      - name: Check go.mods
-        run: |
-          sums="$(sha256sum go.mod misc/devdeps/go.mod)"
-          for path in . ./misc/devdeps; do
-            env -C $path go mod tidy -v || exit 1
-          done
-          echo "$sums" | sha256sum -c
+          token: ${{ secrets.CODECOV_TOKEN }}
+          name: misc
+          flags: misc,misc-${{matrix.args}},go-${{ matrix.go-version }}
+          files: ./misc/coverage.out
+          fail_ci_if_error: false # temporarily

Makefile

@@ -25,6 +25,7 @@ test.components:
 	$(MAKE) --no-print-directory -C gnovm    test
 	$(MAKE) --no-print-directory -C gno.land test
 	$(MAKE) --no-print-directory -C examples test
+	$(MAKE) --no-print-directory -C misc     test
 
 .PHONY: test.docker
 test.docker:

examples/gno.land/p/demo/avl/z_0_filetest.gno

@@ -267,6 +267,8 @@ func main() {
 //                 "FileName": "main.gno",
 //                 "IsMethod": false,
 //                 "Name": "init.0",
+//                 "NativeName": "",
+//                 "NativePkg": "",
 //                 "PkgPath": "gno.land/r/test",
 //                 "Source": {
 //                     "@type": "/gno.RefNode",
@@ -301,6 +303,8 @@ func main() {
 //                 "FileName": "main.gno",
 //                 "IsMethod": false,
 //                 "Name": "main",
+//                 "NativeName": "",
+//                 "NativePkg": "",
 //                 "PkgPath": "gno.land/r/test",
 //                 "Source": {
 //                     "@type": "/gno.RefNode",

examples/gno.land/p/demo/avl/z_1_filetest.gno

@@ -291,6 +291,8 @@ func main() {
 //                 "FileName": "main.gno",
 //                 "IsMethod": false,
 //                 "Name": "init.0",
+//                 "NativeName": "",
+//                 "NativePkg": "",
 //                 "PkgPath": "gno.land/r/test",
 //                 "Source": {
 //                     "@type": "/gno.RefNode",
@@ -325,6 +327,8 @@ func main() {
 //                 "FileName": "main.gno",
 //                 "IsMethod": false,
 //                 "Name": "main",
+//                 "NativeName": "",
+//                 "NativePkg": "",
 //                 "PkgPath": "gno.land/r/test",
 //                 "Source": {
 //                     "@type": "/gno.RefNode",

examples/gno.land/r/demo/boards/z_4_filetest.gno

@@ -374,7 +374,7 @@ func main() {
 //                     "Escaped": true,
 //                     "ObjectID": "336074805fc853987abe6f7fe3ad97a6a6f3077a:2"
 //                 },
-//                 "Index": "188",
+//                 "Index": "189",
 //                 "TV": null
 //             }
 //         }
@@ -541,7 +541,7 @@ func main() {
 //             },
 //             "V": {
 //                 "@type": "/gno.RefValue",
-//                 "Hash": "8164abed5231309c88497013f7da72a1b5d427b0",
+//                 "Hash": "25ffc45509708ca0ae17271cb4c3a1dfb367b965",
 //                 "ObjectID": "f6dbf411da22e67d74cd7ddba6a76cd7e14a4822:115"
 //             }
 //         },
@@ -847,7 +847,7 @@ func main() {
 //             },
 //             "V": {
 //                 "@type": "/gno.RefValue",
-//                 "Hash": "5b4b593f1d4b37cb99166247ea28174f91087fdd",
+//                 "Hash": "a8e67b9881af89ca2ec2f05778bf7528a54a5833",
 //                 "ObjectID": "f6dbf411da22e67d74cd7ddba6a76cd7e14a4822:82"
 //             }
 //         },
@@ -865,7 +865,7 @@ func main() {
 //             },
 //             "V": {
 //                 "@type": "/gno.RefValue",
-//                 "Hash": "7e9fd9bb5e90a06c7751585cd80f23aedddde25b",
+//                 "Hash": "d8ae14a4620e3c6dedabd76cd0c5d7e3c205d647",
 //                 "ObjectID": "f6dbf411da22e67d74cd7ddba6a76cd7e14a4822:83"
 //             }
 //         },

gnovm/Makefile

@@ -58,6 +58,11 @@ _test.gnolang.stdlibs.sync:; go test $(GOTEST_FLAGS) tests/*.go -test.short -run
 
 ########################################
 # Code gen
+# TODO: move _dev.stringer to go:generate instructions, simplify generate
+#       to just go generate.
+.PHONY: generate
+generate: _dev.stringer _dev.generate
+
 stringer_cmd=$(rundep) golang.org/x/tools/cmd/stringer
 .PHONY: _dev.stringer
 _dev.stringer:
@@ -68,5 +73,9 @@ _dev.stringer:
 	$(stringer_cmd) -type=VPType     ./pkg/gnolang
 	$(stringer_cmd) -type=Word       ./pkg/gnolang
 
+.PHONY: _dev.generate
+_dev.generate:
+	go generate -x ./...
+
 # genproto:
 # see top-level Makefile.

gnovm/cmd/gno/testdata/gno_test/realm_correct.txtar

@@ -55,6 +55,8 @@ func main() {
 //                 "FileName": "main.gno",
 //                 "IsMethod": false,
 //                 "Name": "main",
+//                 "NativeName": "",
+//                 "NativePkg": "",
 //                 "PkgPath": "gno.land/r/x",
 //                 "Source": {
 //                     "@type": "/gno.RefNode",

gnovm/cmd/gno/testdata/gno_test/realm_incorrect.txtar

@@ -7,7 +7,7 @@ stderr '=== RUN   file/x_filetest.gno'
 stderr 'panic: fail on x_filetest.gno: diff:'
 stderr '--- Expected'
 stderr '\+\+\+ Actual'
-stderr '@@ -1 \+1,64 @@'
+stderr '@@ -1 \+1,66 @@'
 stderr '-xxx'
 stderr '\+switchrealm\["gno.land/r/x"\]'
 

gnovm/cmd/gno/testdata/gno_test/realm_sync.txtar

@@ -70,6 +70,8 @@ func main() {
 //                 "FileName": "main.gno",
 //                 "IsMethod": false,
 //                 "Name": "main",
+//                 "NativeName": "",
+//                 "NativePkg": "",
 //                 "PkgPath": "gno.land/r/x",
 //                 "Source": {
 //                     "@type": "/gno.RefNode",

gnovm/pkg/gnolang/gno_test.go

@@ -14,7 +14,9 @@ import (
 // run empty main().
 func TestRunEmptyMain(t *testing.T) {
 	m := NewMachine("test", nil)
-	main := FuncD("main", nil, nil, nil)
+	// []Stmt{} != nil, as nil means that in the source code not even the
+	// brackets are present and is reserved for external (ie. native) functions.
+	main := FuncD("main", nil, nil, []Stmt{})
 	m.RunDeclaration(main)
 	m.RunMain()
 }