-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): different address on test caller #662
Conversation
655312f
to
799c9fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Is the reasoning behind this PR that we want to explicitly manage the address of the caller in tests, that's why we fixate it to user1.gno
?
Please resolve the merge conflicts, and we should be good to go 🙏
fix stdlibs tests Co-authored-by: Thomas Bruyelle <[email protected]>
fix(tests): gno.land/r/demo/boards fix(tests): gno.land/r/demo/
799c9fb
to
ca99f96
Compare
Yes, working on other PR require me to have a different address for the caller than the package |
rebased |
Why do we make a change here? the hard coded "user1.gno". The caller becomes hard-coded as "user1.gno"; we can no longer pass in pkgPath as a caller from RunFileTest anymore Line 38 in 721bfc3
The entire "main" package address is changed. Line 101 in 721bfc3
|
Co-authored-by: Thomas Bruyelle <[email protected]>
Description
A lot of our currents works needs to make a difference on the pkg address and the caller address, this PR fix this.