Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add dark theme switcher, and dark theme for hljs #548

Merged
merged 5 commits into from
Mar 2, 2023

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 28, 2023

Completing work started in #515.

Screencast.from.2023-02-28.19-04-21.webm

@thehowl thehowl requested a review from a team as a code owner February 28, 2023 18:06
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

Thank you also for the attributions in-code, it's rare to see these days

gnoland/website/views/funcs.html Outdated Show resolved Hide resolved
gnoland/website/views/funcs.html Outdated Show resolved Hide resolved
gnoland/website/views/funcs.html Outdated Show resolved Hide resolved
gnoland/website/views/funcs.html Outdated Show resolved Hide resolved
@moul
Copy link
Member

moul commented Mar 1, 2023

Looks great 💯

Thank you also for the attributions in-code, it's rare to see these days

let's do it more.

we can't do long-term projects like this without being transparent and fair.

any suggestion on how to improve this with CI/CD, contributions.md?

@thehowl
Copy link
Member Author

thehowl commented Mar 2, 2023

@zivkovicmilos review addressed :)

@moul I think the process can only be part automated. But here's my 2c on how maybe it could be done:

If we want to list all the contributions, we could use All contributors as a starting point for categories to list. I don't necessarily agree with the whole thing (especially the putting-200-images-in-README part). I think it is important that contributions are recognized, while at the same time not making it extra-prominent in the README (to avoid pull requests which fix a typo in a comment or readme file just so that their name can show up on the repository home).

Some of those can be automated (ie. git commit log, github API for PRs/issues), but some of them should probably still come in manually (ie. design).

Then we should list code contributed from external projects. This should be:

  • Dependencies (use go-licenses?)
  • Code snippets like these (although maybe these should be manually added?)
    rg --iglob '!LICENSE*' -i 'Copyright[^0-9]*[0-9]{4}' | rg -iv 'Go authors|Jae Kwon|Tendermint'

If we are listing both contributors and deps/snippets credits, then maybe a CREDITS or THANKS file is more appropriate than a CONTRIBUTIONS or CONTRIBUTORS file.

@moul moul merged commit 74f5f26 into gnolang:master Mar 2, 2023
@moul
Copy link
Member

moul commented Mar 2, 2023

About our contributors, I'm not afraid, we've git to keep track, and we're building Evaluation DAO #407 to manage contributions and contributors at scale.

I was wondering specifically about copyrighted snippets, libs, and inspirations.

I think we can move to #498 if we want to continue the discussion.
If we find a nice way to handle this for contracts, then we can try to adapt the solution for deps in the engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants