feat(examples): add p/demo/avl/list #3324
Open
+747
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <[email protected]>
github-actions
bot
added
the
🧾 package/realm
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
thehowl
reviewed
Dec 11, 2024
| // l := list.New() | ||
| // l.Append(1, 2, 3) | ||
| // println(l.Len()) // Output: 3 | ||
| func New() *List { |
There was a problem hiding this comment.
If the zero value works, then I'd avoid the constructor
| // println(l.Range(-1, 2)) // Output: [1 2] | ||
| // println(l.Range(3, 999)) // Output: [4 5] | ||
| // println(l.Range(3, 2)) // Output: nil | ||
| func (l *List) Range(startIndex, endIndex int) []interface{} { |
| // l.Append(1, 2, 3) | ||
| // l.Clear() | ||
| // println(l.Len()) // Output: 0 | ||
| func (l *List) Clear() { |
There was a problem hiding this comment.
Since the zero value is valid, you can do this no?
*l = list.List{}
| } | ||
| } | ||
|
|
||
| // Clone creates a deep copy of the list. |
There was a problem hiding this comment.
This IMO is shallow. (It doesn't attempt to "copy" values contained within)
| // // With nil default value | ||
| // l2 := list.Make(2, nil) | ||
| // println(l2.Get(0)) // Output: nil | ||
| func Make(length int, defaultValue interface{}) *List { |
There was a problem hiding this comment.
I'm not sure this API makes sense, also because we have no real "benefit" from pre-allocating, and the code to do so is trivial
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could become the preferred method for managing top-level lists.
It can likely be utilized extensively in the existing codebase, potentially for most instances involving a top-level slice or those involving an avl.Tree using a seqid.