feat(boards2): board creation and permissions #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caller must have a user registered in the users realm or pay a fee to create new boards. Changeset also renames `gAuth` to `gPerm`.
Renamed to follow the preferred name that has been mentioned during board requirements discussions.
Board creation function should not check if the name is duplicated.
This handler deals with permissioner checks for board creation using the `WithPermission` function.
At this point we deal with whitelisted users that are member of the boards realm DAO when creating boards. Anonymous users can't create boards at this point.
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
This validation makes sure only owners can invite other owners.
jeronimoalbi
commented
Nov 27, 2024
Comment on lines
+165
to
+166
| perms.HandleFunc(PermissionBoardCreate, handleBoardCreate) | ||
| perms.HandleFunc(PermissionMemberInvite, handleMemberInvite) |
There was a problem hiding this comment.
This is one way to let the Permissioner implementation deal with specific permission logic. Not an elegant approach but initially it works, we could improve it and discuss ideas also as another issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3140