-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(govdao): better rendering #3096
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
@leohhhn can you add the prop title in the list too? Maybe just the N first chars. |
I was about to; but then i realized there isn't a title field in the prop structure/interface. Is there a reason for this? If not, I can add it (I did the same thing in my previous PR) |
Yeah, I think it makes sense for a prop to have a required title and an optional or required description. |
Can be useful for #3096. --------- Signed-off-by: moul <[email protected]>
Made some more changes. Check out the comments & the prop page that was updated a bit. |
Merge RequirementsThe following requirements must be fulfilled before a pull request can be merged. These requirements are defined in this configuration file. Automated Checks🟢 Maintainers must be able to edit this pull request Details
Manual Checks
Details
|
Description
Introduces better
gnoweb
rendering for the GovDAO suite, and better help page actions for voting on proposals.Home page before:
Home page after (also resolves usernames from
r/demo/users
):Prop page before:
Prop page after:
The actions bar notifies the user when the proposal is no longer active as well.
Continuation of #2579
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description