Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tx-archive in portal loop #3064

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

This PR updates the tx-archive version in portal loop to use the new standard gnoland.TxWithMetadata format for transaction sheets.

BREAKING CHANGE
The portal loop will now save transactions with the new metadata format

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@zivkovicmilos zivkovicmilos added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Nov 4, 2024
@zivkovicmilos zivkovicmilos self-assigned this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.33%. Comparing base (c776e32) to head (22f1c1b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3064   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files         548      548           
  Lines       78600    78599    -1     
=======================================
+ Hits        49778    49784    +6     
+ Misses      25465    25460    -5     
+ Partials     3357     3355    -2     
Flag Coverage Δ
contribs/gnodev 61.11% <ø> (+0.62%) ⬆️
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 67.35% <ø> (ø)
gnovm 67.88% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.29% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos zivkovicmilos added the breaking change Functionality that contains breaking changes label Nov 4, 2024
@sw360cab sw360cab merged commit e3995b9 into master Nov 4, 2024
131 checks passed
@sw360cab sw360cab deleted the dev/zivkovicmilos/update-portal-loop branch November 4, 2024 21:12
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Nov 5, 2024
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Functionality that contains breaking changes 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants