Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): fix issue with locally re-definition #3014

Merged
merged 13 commits into from
Oct 24, 2024

Conversation

ltzmaxwell
Copy link
Contributor

@ltzmaxwell ltzmaxwell commented Oct 23, 2024

closes: #3013

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 23, 2024
@ltzmaxwell ltzmaxwell changed the title fix(gnovm): fix issue with locally re-definition WIP fix(gnovm): fix issue with locally re-definition Oct 23, 2024
@Kouteki Kouteki added the 🐞 bug Something isn't working label Oct 23, 2024
@Kouteki Kouteki added this to the 🚀 Mainnet launch milestone Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.39%. Comparing base (520195e) to head (4aea025).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3014      +/-   ##
==========================================
+ Coverage   63.38%   63.39%   +0.01%     
==========================================
  Files         565      565              
  Lines       79461    79457       -4     
==========================================
+ Hits        50364    50372       +8     
+ Misses      25703    25693      -10     
+ Partials     3394     3392       -2     
Flag Coverage Δ
contribs/gnodev 59.94% <ø> (-0.63%) ⬇️
contribs/gnofaucet 15.77% <ø> (+0.94%) ⬆️
gno.land 67.37% <ø> (ø)
gnovm 67.87% <100.00%> (+<0.01%) ⬆️
misc/genstd 79.72% <ø> (ø)
tm2 62.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltzmaxwell ltzmaxwell changed the title WIP fix(gnovm): fix issue with locally re-definition fix(gnovm): fix issue with locally re-definition Oct 23, 2024
@ltzmaxwell
Copy link
Contributor Author

cc: @thehowl @petar-dambovaliev @mvertes @zivkovicmilos for deeper insights.

Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@thehowl thehowl merged commit 287c22e into gnolang:master Oct 24, 2024
118 checks passed
@Kouteki Kouteki added in focus Core team is prioritizing this work and removed in focus Core team is prioritizing this work labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Running gno test causes a panic when struct variables are redeclared in loops
4 participants