Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: benchmark only BenchmarkBenchdata #3007

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Oct 23, 2024

A bit radical, but I'm open to other benchmarks we should include.

Essentially, in an effort to have a small amount of meaningful benchmarks, I'd like for these to only be those in BenchmarkBenchdata. Yes, I recognize this is tooting my own horn, but I think they are good benchmarks that tell us, overall, if the GnoVM on a few reference programs got slower or faster, and I found them useful in the past while doing manual execution.

Most other benchmarks are micro-benchmarks, which aren't likely to change often or to give us useful insight. I'm open to suggestions for others that make sense to be tracked, but I think it's for the better if we keep the number low so the CI for benchmarks can run in just a few minutes.

@thehowl thehowl requested a review from sw360cab October 23, 2024 19:53
@thehowl thehowl self-assigned this Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.

Project coverage is 63.38%. Comparing base (520195e) to head (81d6dea).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/uverse.go 80.00% 4 Missing ⚠️
gno.land/pkg/keyscli/run.go 66.66% 1 Missing ⚠️
gno.land/pkg/sdk/vm/keeper.go 0.00% 1 Missing ⚠️
gnovm/pkg/gnolang/machine.go 75.00% 1 Missing ⚠️
gnovm/pkg/gnolang/nodes.go 83.33% 1 Missing ⚠️
gnovm/pkg/gnolang/store.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
- Coverage   63.38%   63.38%   -0.01%     
==========================================
  Files         565      566       +1     
  Lines       79461    79490      +29     
==========================================
+ Hits        50364    50382      +18     
- Misses      25703    25716      +13     
+ Partials     3394     3392       -2     
Flag Coverage Δ
contribs/gnodev 60.57% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 67.37% <77.77%> (ø)
gnovm 67.87% <85.10%> (+<0.01%) ⬆️
misc/genstd 79.72% <ø> (ø)
tm2 62.46% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl requested review from jaekwon, piux2 and a team as code owners October 23, 2024 20:03
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 23, 2024
@thehowl thehowl merged commit cfbaff2 into master Oct 25, 2024
119 checks passed
@thehowl thehowl deleted the dev/morgan/strip-benchmarks branch October 25, 2024 21:43
@thehowl thehowl mentioned this pull request Oct 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants