-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnolang): ensure complete Uverse initialization #2997
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2997 +/- ##
==========================================
+ Coverage 63.18% 63.40% +0.21%
==========================================
Files 561 565 +4
Lines 78636 79473 +837
==========================================
+ Hits 49690 50389 +699
- Misses 25569 25690 +121
- Partials 3377 3394 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FYI, I tested and this fixes the "flappy" test reported in this comment. |
Fixes #2067.
UverseNode now distinguishes when it's uninitialized, initializing and initialized. In combination with calling Uverse() at init, we make sure that after package initialization we always have the same result from Uverse() and UverseNode() and we don't have issues like those pointed out in #2067.