chore(cmd/gnoland): disable --flag-config-path #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2991 +/- ##
==========================================
- Coverage 63.08% 63.08% -0.01%
==========================================
Files 563 563
Lines 79266 79255 -11
==========================================
- Hits 50008 50000 -8
+ Misses 25893 25890 -3
Partials 3365 3365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <[email protected]>
moul
force-pushed
the
dev/moul/disable-flag-config-path
branch
from
3b50d21
to
5d1e36a
Compare
zivkovicmilos
approved these changes
Oct 21, 2024
|
The feature is usually cool, but in our case, since we already have other concepts of a "config file," it can create unnecessary complexity. That's why I prefer to remove it if nobody is asking to keep it. |
thehowl
approved these changes
Oct 21, 2024
thehowl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about this one. Is anyone using it?