Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd/aminoscan): set len=0 in a slice initialization #2971

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix(cmd/aminoscan): set len=0 in a slice initialization #2971

merged 1 commit into from
Oct 18, 2024

Conversation

rusttech
Copy link
Contributor

@rusttech rusttech commented Oct 17, 2024 •
edited
Loading

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

The intention here should be to initialize a slice with a capacity of len(args) rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Oct 17, 2024
@rusttech rusttech changed the title fix: fix slice init length fix(tm2): fix slice init length Oct 17, 2024
@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 18, 2024
@notJoon notJoon removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 18, 2024
@notJoon
Copy link
Member

notJoon commented Oct 18, 2024

Removed the review/triage-pending flag. This is pratice and does not affect the functionality of existing features.

@thehowl thehowl changed the title fix(tm2): fix slice init length fix(cmd/aminoscan): set len=0 in a slice initialization Oct 18, 2024
@thehowl thehowl merged commit b655cd2 into gnolang:master Oct 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@thehowl thehowl thehowl approved these changes

@moul moul moul approved these changes

@jaekwon jaekwon Awaiting requested review from jaekwon

@piux2 piux2 Awaiting requested review from piux2

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

Assignees

@rusttech rusttech

Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
💪 Bounties & Worx
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rusttech @notJoon @moul @thehowl @jefft0