wip(keeper): implement json primitive return #2949
Draft
+442
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
github-actions
bot
added
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2949 +/- ##
==========================================
+ Coverage 60.83% 60.89% +0.06%
==========================================
Files 563 563
Lines 75193 75211 +18
==========================================
+ Hits 45743 45803 +60
+ Misses 26076 26046 -30
+ Partials 3374 3362 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
reviewed
Oct 17, 2024
|
|
||
| rtvs := m.Eval(xn) | ||
| stringifyResultValues(m, msg.Format, rtvs) |
|
|
||
| const ( | ||
| FormatMachine = "machine" // Default machine representation | ||
| FormatJSON = "json" |
There was a problem hiding this comment.
Maybe let's add a comment like // XXX: EXPERIMENTAL, only supports primitive types for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another JSON PR 🎉
This is a simpler implementation of the JSON keeper result that introduces JSON primitive results in keeper MsgCall and MsgQuery result. To maintain backward compatibility, it's not enabled by default, and you have to specify the format in the request.
The result will be returned in the form of a parsable JSON array.
Currently, it will resolve types as follows:
<oid:type>as string<type>as stringTODOs
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description