fix: Fixes #2938 GnoVM Unexpected Crash When Panic Occurs in Tests

[salihdhaifullah]

fixed panic crash on gno test by correctly formatting the argument for m.Panic

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[notJoon]

Thank you for contributing. Could you please add some test for this?

[salihdhaifullah]

I have added a test file i hope i did that right

[notJoon]

The modified lines seem fine and the tests are running well.

Result

$ cd gnovm/cmd/gno 
$ go test -v . -run Test_Scripts/gno_test/panic_error

=== RUN   Test_Scripts
    testdata_test.go:27: testing: gno_fmt
    testdata_test.go:27: testing: gno_lint
    testdata_test.go:27: testing: gno_test
=== RUN   Test_Scripts/gno_test
=== RUN   Test_Scripts/gno_test/panic_error
=== PAUSE Test_Scripts/gno_test/panic_error
=== CONT  Test_Scripts/gno_test/panic_error
    testscript.go:558: WORK=$WORK
        PATH=/* ... */
        GOTRACEBACK=system
        HOME=/var/folders/sb/8c04v17n44zd7x__zvgs2vz00000gn/T/gno3283009104
        TMPDIR=$WORK/.tmp
        devnull=/dev/null
        /=/
        :=:
        $=$
        exe=
        GNOROOT=/Users/notJoon/gno-core
        GO111MODULE=off
        
        # Test panic with error output in a test (1.069s)
        > ! gno test .
        [stderr]
        --- WARNING: unable to read package path from gno.mod or gno root directory; try creating a gno.mod file
        panic: hello world
        --- FAIL: TestPanicWithError (0.00s)
        .: test pkg: failed: "TestPanicWithError"
        FAIL
        FAIL    .       0.65s
        FAIL
        FAIL
        FAIL: 0 build errors, 1 test errors
        
        gno command error: exit status 1
        > ! stdout .+
        > stderr '--- FAIL: TestPanicWithError'
        > stderr 'panic: hello world'
        > stderr 'FAIL'
        PASS

remove review/triage-pending flag due to the above reason

[thehowl]

Thank you for your contribution. This PR is not a good way to approach the problem, as it's changing the behaviour of how we panic, by special-casing in the GnoVM what happens from the panic message. This is bad.

What we should do instead, is that we can understand error values in gno2go, and handle them accordingly, ie. converting them to Go errors, so that the call to functions like Printf work properly. This is not ideal either, but preferable since gno2go code only concerns testing and there is a long-term plan to remove it: #1361

I'm closing this PR; feel free to make a new one with a new approach.