feat(boardsv2): experiment API - WIP #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: İlker G. Öztürk <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devx/feature/boardsv2 #2902 +/- ##
=========================================================
- Coverage 60.97% 60.93% -0.04%
=========================================================
Files 564 564
Lines 75273 77864 +2591
=========================================================
+ Hits 45898 47447 +1549
- Misses 26007 27050 +1043
+ Partials 3368 3367 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ltzmaxwell
reviewed
Oct 4, 2024
Co-authored-by: İlker G. Öztürk <[email protected]> Co-authored-by: Denys Sedchenko <[email protected]>
This changes are just one idea in case we want to consider using a single type, like Post or Node for example, for all board types. The proposed ideas here are based on points discussed by the team up to this point of the definition. The idea is to see if we can define a good pattern to implement the boards (boards, posts, comments, ...) using a single type as mentioned by Jae at some point during early discussions. These changes are NOT finished, they are a "showcase" for further exploration and discussion at this point.
Maybe by using an storage abstraction and functions we could deal with specific features like up/down voting, creationg of different post types, and so on. This would keep the Post type simple and features would be handled by the different storage abstractions.
ilgooz
reviewed
Oct 7, 2024
Co-authored-by: İlker G. Öztürk <[email protected]>
Co-authored-by: İlker G. Öztürk <[email protected]>
ilgooz
force-pushed
the
devx/feature/boardsv2-experiment1
branch
from
c0c0237
to
0b81834
Compare
Co-authored-by: İlker G. Öztürk <[email protected]>
Co-authored-by: İlker G. Öztürk <[email protected]>
Co-authored-by: İlker G. Öztürk <[email protected]>
ilgooz
reviewed
Oct 11, 2024
ilgooz
reviewed
Oct 11, 2024
These changes were done before the change of direction for the boards implementation. Commiting them to avoid loosing the ideas and improvements present here.
|
@ilgooz I'm going to quickly address the two comments so we can merge it into the feature branch |
Co-authored-by: İlker G. Öztürk <[email protected]>
|
Follow up #2901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boards v2 package and realm API experimentation
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description