Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stdlib): io test #2898

Merged
merged 6 commits into from
Oct 23, 2024
Merged

fix(stdlib): io test #2898

merged 6 commits into from
Oct 23, 2024

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Oct 4, 2024

Description

Fixed a failing test in the io package. Additionally, I activated some previously commented-out tests by bypassing the need for os.CreateTemp using bytes.Buffer.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.57%. Comparing base (5e71837) to head (bcd6b19).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2898      +/-   ##
==========================================
+ Coverage   63.39%   63.57%   +0.18%     
==========================================
  Files         565      565              
  Lines       79390    79471      +81     
==========================================
+ Hits        50329    50524     +195     
+ Misses      25673    25564     -109     
+ Partials     3388     3383       -5     
Flag Coverage Δ
contribs/gnodev 60.57% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 67.37% <ø> (ø)
gnovm 67.86% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.47% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notJoon notJoon changed the title fix io test fix(stdlib): io test Oct 4, 2024
@notJoon notJoon marked this pull request as ready for review October 4, 2024 06:04
@notJoon notJoon requested a review from thehowl as a code owner October 4, 2024 06:04
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of exporting the errors, I'd rather we kept them unexported and put the test in package io (instead of io_test).

@notJoon
Copy link
Member Author

notJoon commented Oct 4, 2024

Instead of exporting the errors, I'd rather we kept them unexported and put the test in package io (instead of io_test).

Changed the error types to private and modified the test package declaration from io_test to io.

The ErrShortWrite, EOF, ErrUnexpectedEOF, and ErrNoProgress errors remain public, as they are also used in the bufio package.

a63bb39

@notJoon notJoon requested a review from thehowl October 4, 2024 09:51
gnovm/stdlibs/io/io.gno Outdated Show resolved Hide resolved
@thehowl thehowl merged commit d961785 into gnolang:master Oct 23, 2024
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants