-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stdlib): io test #2898
fix(stdlib): io test #2898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2898 +/- ##
==========================================
+ Coverage 63.39% 63.57% +0.18%
==========================================
Files 565 565
Lines 79390 79471 +81
==========================================
+ Hits 50329 50524 +195
+ Misses 25673 25564 -109
+ Partials 3388 3383 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of exporting the errors, I'd rather we kept them unexported and put the test in package io
(instead of io_test).
Changed the error types to private and modified the test package declaration from The |
Description
Fixed a failing test in the io package. Additionally, I activated some previously commented-out tests by bypassing the need for
os.CreateTemp
usingbytes.Buffer
.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description