Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): prevent assignment to non-assignable expressions #2896

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

omarsy
Copy link
Member

@omarsy omarsy commented Oct 3, 2024

closes: #2889

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.12%. Comparing base (af05780) to head (fbc3bbe).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/type_check.go 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2896      +/-   ##
==========================================
- Coverage   63.32%   63.12%   -0.21%     
==========================================
  Files         548      548              
  Lines       78511    80213    +1702     
==========================================
+ Hits        49719    50636     +917     
- Misses      25438    26171     +733     
- Partials     3354     3406      +52     
Flag Coverage Δ
contribs/gnodev 60.57% <ø> (ø)
contribs/gnofaucet 15.77% <ø> (+0.94%) ⬆️
gno.land 67.18% <ø> (ø)
gnovm 67.90% <92.85%> (+0.02%) ⬆️
misc/genstd 79.72% <ø> (ø)
tm2 62.37% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omarsy omarsy requested a review from thehowl October 18, 2024 16:12
@ltzmaxwell ltzmaxwell changed the title chore(gnovm): prevent assignment to non-assignable expressions fix(gnovm): prevent assignment to non-assignable expressions Oct 25, 2024
@ltzmaxwell
Copy link
Contributor

should share some logic with this: #1946

gnovm/pkg/gnolang/type_check.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/type_check.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @ltzmaxwell please do merge after you're satisfied with the feedback

@ltzmaxwell ltzmaxwell merged commit 7ef606c into gnolang:master Nov 7, 2024
125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Assigning Type as Value in Gno should be prohibited
4 participants