Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codeowners): add codeowners for boardsv2 #2883

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

ilgooz
Copy link
Contributor

@ilgooz ilgooz commented Oct 2, 2024

No description provided.

@ilgooz ilgooz changed the title codeowners: add codeowners for boardsv2 chore(codeowners): add codeowners for boardsv2 Oct 2, 2024
@thehowl
Copy link
Member

thehowl commented Oct 2, 2024

note, we're going to do #2788 once we have a bot that can actually put review requirements before merging, and move towards using codeowners mostly as a way to ping people for reviews.

we can go ahead and merge this for now, just keep in mind that if you want it as a way to be required for review it's eventually going to be a different mechanism.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.91%. Comparing base (11a5027) to head (83241a2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2883      +/-   ##
==========================================
- Coverage   60.92%   60.91%   -0.01%     
==========================================
  Files         564      564              
  Lines       75273    75273              
==========================================
- Hits        45857    45852       -5     
- Misses      26048    26051       +3     
- Partials     3368     3370       +2     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 67.17% <ø> (ø)
gnovm 65.77% <ø> (ø)
misc/logos 19.88% <ø> (-0.36%) ⬇️
tm2 61.97% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Manfred Touron <[email protected]>
@ilgooz ilgooz merged commit 7f39d04 into master Oct 2, 2024
119 checks passed
@ilgooz ilgooz deleted the ilgooz/codeowners-boardsv2 branch October 2, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants