Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(gno.land/sdk/vm): add unit tests for Msg*.ValidateBasic #2855

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

sunspirit99
Copy link
Contributor

The vm Msg is not yet covered by unit tests

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Sep 26, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.95%. Comparing base (4f6ca96) to head (ef4e013).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2855      +/-   ##
==========================================
+ Coverage   60.91%   60.95%   +0.04%     
==========================================
  Files         564      564              
  Lines       75273    75273              
==========================================
+ Hits        45851    45884      +33     
+ Misses      26053    26015      -38     
- Partials     3369     3374       +5     
Flag Coverage Δ
contribs/gnodev 60.65% <ø> (-0.82%) ⬇️
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 67.92% <ø> (+0.75%) ⬆️
gnovm 65.77% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+0.35%) ⬆️
tm2 62.07% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gno.land/pkg/sdk/vm/msg_test.go Outdated Show resolved Hide resolved
gno.land/pkg/sdk/vm/msg_test.go Outdated Show resolved Hide resolved
gno.land/pkg/sdk/vm/msg_test.go Outdated Show resolved Hide resolved
gno.land/pkg/sdk/vm/msg_test.go Outdated Show resolved Hide resolved
@ltzmaxwell
Copy link
Contributor

LGTM, cross reference #2409 (review) for future improve, at least we can add PkgExistError for now.

@thehowl thehowl changed the title feat(gno.land): Add unit tests for vm Msg test(gno.land/sdk/vm): add unit tests for Msg*.ValidateBasic Oct 2, 2024
@thehowl
Copy link
Member

thehowl commented Oct 2, 2024

LGTM, cross reference #2409 (review) for future improve, at least we can add PkgExistError for now.

yes; though we already test it in keeper_test.go ;)

@thehowl thehowl merged commit ee2b1fa into gnolang:master Oct 2, 2024
120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants