Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(tm2/bft/fail): use sync.Once instead of Getenv on each call #2805

Merged
merged 1 commit into from
Sep 18, 2024

perf(bft/fail): use sync.Once instead of fetching Getenv on each call

78ed413
Select commit
Loading
Failed to load commit list.
Merged

perf(tm2/bft/fail): use sync.Once instead of Getenv on each call #2805

perf(bft/fail): use sync.Once instead of fetching Getenv on each call
78ed413
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 16, 2024 in 0s

60.86% (+0.03%) compared to 5503cca

View this Pull Request on Codecov

60.86% (+0.03%) compared to 5503cca

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.86%. Comparing base (5503cca) to head (78ed413).

Files with missing lines Patch % Lines
tm2/pkg/bft/fail/fail.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2805      +/-   ##
==========================================
+ Coverage   60.83%   60.86%   +0.03%     
==========================================
  Files         563      563              
  Lines       75193    75190       -3     
==========================================
+ Hits        45743    45765      +22     
+ Misses      26076    26058      -18     
+ Partials     3374     3367       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.