Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grc20): remove unused interface, fix typo #2793

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Sep 13, 2024

Description

This PR removes a duplicate, unused interface from the GRC20 package, and fixes a typo.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • [x Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn requested review from a team as code owners September 13, 2024 09:37
@leohhhn leohhhn requested review from sw360cab and ltzmaxwell and removed request for a team September 13, 2024 09:37
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.83%. Comparing base (bde8afc) to head (36f7ef4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2793      +/-   ##
==========================================
+ Coverage   60.80%   60.83%   +0.02%     
==========================================
  Files         563      563              
  Lines       75158    75516     +358     
==========================================
+ Hits        45703    45937     +234     
- Misses      26086    26173      +87     
- Partials     3369     3406      +37     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 67.21% <ø> (ø)
gnovm 65.59% <ø> (+0.07%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+0.35%) ⬆️
tm2 61.95% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn leohhhn merged commit 11d29a2 into gnolang:master Sep 13, 2024
120 checks passed
@leohhhn leohhhn deleted the fix/grc20 branch September 13, 2024 10:15
@leohhhn leohhhn mentioned this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants