Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(portal-loop): mention packages can be deployed permissionlessly #2747

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

grepsuzette
Copy link
Contributor

Referencing #2744

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.21%. Comparing base (701ac17) to head (4ff07ea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
- Coverage   60.21%   60.21%   -0.01%     
==========================================
  Files         562      562              
  Lines       75038    75038              
==========================================
- Hits        45185    45182       -3     
- Misses      26476    26479       +3     
  Partials     3377     3377              
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 64.57% <ø> (ø)
gnovm 64.33% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.04% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is needed, just in more broader terms. Please see my comment.

docs/concepts/portal-loop.md Outdated Show resolved Hide resolved
docs/concepts/portal-loop.md Outdated Show resolved Hide resolved
docs/concepts/portal-loop.md Outdated Show resolved Hide resolved
@leohhhn
Copy link
Contributor

leohhhn commented Sep 2, 2024

Let's merge this and iterate.

@leohhhn leohhhn merged commit 68ef445 into gnolang:master Sep 2, 2024
119 of 120 checks passed
@grepsuzette grepsuzette deleted the docs-portalloop-permissionless branch September 3, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants