-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): a shifumi (rock, paper, scissors) smart contract #2629
Conversation
A very simple game as a smart contract. It's possible to play against yourself, or another opponent. UI could be improved. No provision against cheating, no gain or automatic action. Related to gnolang#611.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2629 +/- ##
==========================================
- Coverage 60.21% 60.20% -0.01%
==========================================
Files 562 562
Lines 75038 75038
==========================================
- Hits 45184 45180 -4
- Misses 26479 26480 +1
- Partials 3375 3378 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few suggestions for good practices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
A very simple game as a smart contract. It's possible to play against yourself, or another opponent. UI could be improved.
No provision against cheating, no gain or automatic action.
Related to #611.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description