Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gnoland): Update error type for invalid deposit #2614

Merged
merged 5 commits into from
Jul 29, 2024
Merged

fix(gnoland): Update error type for invalid deposit #2614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3bae32
use error correctly
linhpn99 Jul 22, 2024
3373886
Merge branch 'master' into fix-invalid-deposit-error
linhpn99 Jul 23, 2024
f5e2a15
Merge branch 'master' into fix-invalid-deposit-error
linhpn99 Jul 24, 2024
ff3ad23
change to amt.String()
linhpn99 Jul 26, 2024
8326a7e
Merge branch 'master' into fix-invalid-deposit-error
linhpn99 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gno.land/pkg/sdk/vm/msgs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
return ErrInvalidPkgPath("missing package path")
}
if !msg.Deposit.IsValid() {
return std.ErrTxDecode("invalid deposit")
return std.ErrInvalidCoins(msg.Deposit.String())

Check warning on line 60 in gno.land/pkg/sdk/vm/msgs.go

View check run for this annotation

Codecov / codecov/patch

gno.land/pkg/sdk/vm/msgs.go#L60 

Added line #L60 was not covered by tests
}
// XXX validate files.
return nil
Expand Down
2 changes: 1 addition & 1 deletion tm2/pkg/sdk/bank/msgs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
return std.ErrInvalidAddress("missing recipient address")
}
if !msg.Amount.IsValid() {
return std.ErrInvalidCoins("send amount is invalid: " + msg.Amount.String())
return std.ErrInvalidCoins(msg.Amount.String())

Check warning on line 42 in tm2/pkg/sdk/bank/msgs.go

View check run for this annotation

Codecov / codecov/patch

tm2/pkg/sdk/bank/msgs.go#L42 

Added line #L42 was not covered by tests
thehowl marked this conversation as resolved.
Show resolved Hide resolved
}
if !msg.Amount.IsAllPositive() {
return std.ErrInsufficientCoins("send amount must be positive")
Expand Down
Loading