Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cache types to avoid inconsistencies #2606

Closed
wants to merge 2 commits into from

Conversation

ajnavarro
Copy link
Contributor

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (92e51c2) to head (ee7873b).
Report is 73 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2606      +/-   ##
==========================================
+ Coverage   55.02%   55.03%   +0.01%     
==========================================
  Files         595      595              
  Lines       79665    79628      -37     
==========================================
- Hits        43837    43827      -10     
+ Misses      32512    32489      -23     
+ Partials     3316     3312       -4     
Flag Coverage Δ
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Antonio Navarro Perez <[email protected]>
@thehowl
Copy link
Member

thehowl commented Sep 13, 2024

Closing for now, as the problem is deeper and cacheTypes is sadly just the tip of the iceberg.

here I made a proposal for how we can move forward to try and eventually remove cache problems from the gno store.

@thehowl thehowl closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants