feat(examples): forms #2604
Open
feat(examples): forms #2604
+944
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2604 +/- ##
==========================================
- Coverage 60.15% 60.15% -0.01%
==========================================
Files 561 561
Lines 74999 74999
==========================================
- Hits 45117 45113 -4
- Misses 26505 26507 +2
- Partials 3377 3379 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leohhhn
requested review from
jaekwon and
gfanton
and removed request for
a team
leohhhn
approved these changes
Jul 21, 2024
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
gfanton
approved these changes
Aug 2, 2024
Co-authored-by: Guilhem Fanton <[email protected]>
Co-authored-by: Guilhem Fanton <[email protected]>
Kouteki
added
the
review/triage-pending
jefft0
removed
the
review/triage-pending
|
Removed the "review team" label because this is already reviewed by core devs. |
ltzmaxwell
reviewed
Oct 4, 2024
Comment on lines
+18
to
+47
| type times struct { | ||
| openAt *time.Time | ||
| closeAt *time.Time | ||
| } | ||
|
|
||
| func parseDates(openAt string, closeAt string) (times, error) { | ||
| var openAtTime, closeAtTime *time.Time | ||
|
|
||
| const dateFormat = "2006-01-02T15:04:05Z" | ||
|
|
||
| // Parse openAt if it's not empty | ||
| if openAt != "" { | ||
| res, err := time.Parse(dateFormat, openAt) | ||
| if err != nil { | ||
| return times{}, errInvalidDate | ||
| } | ||
| openAtTime = &res | ||
| } | ||
|
|
||
| // Parse closeAt if it's not empty | ||
| if closeAt != "" { | ||
| res, err := time.Parse(dateFormat, closeAt) | ||
| if err != nil { | ||
| return times{}, errInvalidDate | ||
| } | ||
| closeAtTime = &res | ||
| } | ||
|
|
||
| return times{openAtTime, closeAtTime}, nil | ||
| } |
There was a problem hiding this comment.
- this(
times) seems to be a redundant design; - using time.Time directly (without a pointer) is perfectly fine.
@leohhhn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the student contributor program, I attempted to create a new example realm that allows the creation and submission of forms on gno !
Features
CreateForm(...)SubmitForm(...)GetForms(...), GetFormByID(...), GetAnswer(...)Field Types
The system supports the following field types:
{"label": "Name", "fieldType": "string", "required": true}{"label": "Age", "fieldType": "number", "required": true}{"label": "Is Student?", "fieldType": "boolean", "required": false}Demo
The external repo where the initial development took place and where you can find the frontend is here.
The web app itself is hosted here
And the most recent test4 version of the contract is forms2
Screenshots :
gnoweb Render()
a form response in the web interface
creating a form in the web interface
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description