Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Namespaces page & fix minor typos #2599

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Jul 17, 2024

Description

This PR updates the Namespaces page to make it more consistent and readable, and updates a few typos in relation to a few missed words in this PR. It renames the Namespaces page to Package Paths.

Matching docs PR: gnolang/docs.gno.land#50

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn marked this pull request as ready for review July 17, 2024 14:21
@leohhhn leohhhn requested review from a team and moul as code owners July 17, 2024 14:21
Copy link
Contributor

@deelawn deelawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid changes. A few things should be fixed and I'd like some input on how we should be referring to packages, pure packages, and realms -- and do so consistently. Of course, that might be out of scope for this PR so we could always punt that particular item to another issue.


# Package Paths

A package path is a unique identifier for each package/realm. It specifies the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there needs to be package/realm everywhere. We can just refer to them generally as packages and make the distinction between pure packages and realms when it is necessary.

Edit after looking through this and existing package docs more:
IMO we should refer to things throughout the docs as "pure packages" or "realms" as necessary and reserve "package" as a term that refers to both. This way the term "package path" makes sense that is should apply to both pure packages and realms, not only to what we currently refer to as packages (actually pure packages). What do you think?

You can use a package path to:

- Call a specific function from a package/realm. (e.g using `gnokey maketx call`)
- Import it in other packages/realms.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Import it in other packages/realms.
- Import it from other packages/realms.

- Domain: The domain of the blockchain where the package is deployed.
Currently, only `gno.land/` is supported.
- Type: Defines the type of package.
- `p/`: [Package](packages.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `p/`: [Package](packages.md)
- `p/`: [Pure Package](packages.md)


:::warning Namespaces on gno.land testnets

This feature is currently only enabled on the [Test4 testnet](./testnets.md#test4).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reword this to clarify it is enabled on all networks from test4 and beyond, excluding portal loop. This way it won't have to be updated when we launch (test5? 😅 ) mainnet.

## Registering a namespace

To register a namespace, you need to use the `r/demo/users` realm. It allows
users to register a username for a fee of 200 `GNOTs`, which is in turn used as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
users to register a username for a fee of 200 `GNOTs`, which is in turn used as
users to register a username, for a fee of 200 `GNOTs`, which is in turn used as

Makes it clear that the username is the thing being used as a reference for the namespace of the user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I've not typed out a lot of digital currency amounts in markdown, but it seems like 200 GNOT seems more natural than 200 GNOTs. I don't know of any other digital tokens where people use the plural of the token's symbol to reference more than one -- 5 "eth", 10 "sol", 7 "atom", etc.

-gas-fee 1000000ugnot -gas-wanted 2000000 \
-broadcast \
-chainid=test4 \
-remote https://rpc.test4.gno.land
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-remote https://rpc.test4.gno.land
-remote https://rpc.test4.gno.land \


After successful registration, you can add a package under your registered namespace.

## Anonymous Namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't describe the namespace as anonymous -- there is an address associated with it. Perhaps "Eponymous Namespace" is more fitting here.

--gas-wanted 2000000 \
--broadcast \
--chainid test4 \
-remote https://rpc.test4.gno.land
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-remote https://rpc.test4.gno.land
--remote https://rpc.test4.gno.land \

Also when we have blocks of multiline commands in the same doc like this, it would be good to keep the flags consistent -- one dash vs two for example. You and I know there is no difference, but it might be confusing to a newbie just getting started with command line tools.

Copy link

github-actions bot commented Nov 7, 2024

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added the Stale label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants