Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(gnoclient): Fix a potential bug in the integration test #2558

Merged
merged 3 commits into from
Jul 9, 2024
Merged

test(gnoclient): Fix a potential bug in the integration test #2558

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28d3cb2
assert nil error before checking result
linhpn99 Jul 9, 2024
fc8c8df
Merge branch 'master' into potential-gnoclient-bug
linhpn99 Jul 9, 2024
29ae0e1
Apply suggestions from code review
thehowl Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions gno.land/pkg/gnoclient/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ func TestCallSingle_Integration(t *testing.T) {

// Execute call
res, err := client.Call(baseCfg, msg)
require.NoError(t, err)

expected := "(\"hi test argument\" string)\n\n"
got := string(res.DeliverTx.Data)

assert.Nil(t, err)
assert.Equal(t, expected, got)
}

Expand Down Expand Up @@ -107,9 +107,9 @@ func TestCallMultiple_Integration(t *testing.T) {

// Execute call
res, err := client.Call(baseCfg, msg1, msg2)
require.NoError(t, err)

got := string(res.DeliverTx.Data)
assert.Nil(t, err)
assert.Equal(t, expected, got)
}

Expand Down Expand Up @@ -149,12 +149,12 @@ func TestSendSingle_Integration(t *testing.T) {

// Execute send
res, err := client.Send(baseCfg, msg)
assert.Nil(t, err)
require.NoError(t, err)
assert.Equal(t, "", string(res.DeliverTx.Data))

// Get the new account balance
account, _, err := client.QueryAccount(toAddress)
assert.Nil(t, err)
require.NoError(t, err)

expected := std.Coins{{"ugnot", int64(amount)}}
got := account.GetCoins()
Expand Down Expand Up @@ -409,7 +409,7 @@ func Echo(str string) string {

// Execute AddPackage
_, err = client.AddPackage(baseCfg, msg)
assert.Nil(t, err)
assert.NoError(t, err)

// Check for deployed file on the node
query, err := client.Query(QueryCfg{
Expand Down Expand Up @@ -501,7 +501,7 @@ func Hello(str string) string {

// Execute AddPackage
_, err = client.AddPackage(baseCfg, msg1, msg2)
assert.Nil(t, err)
assert.NoError(t, err)

// Check Package #1
query, err := client.Query(QueryCfg{
Expand Down
Loading