Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pyroscope and updates compose #2536

Closed
wants to merge 11 commits into from

Conversation

Leon-Africa
Copy link

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.
FIX:
Set container names

Set network name

Add Grafana pyroscope

Instead of pulling ghcr.io image - Setup a local docker to build allowing that local low level changes made can be tested immediately. 

Add option to build with no-cache [make up fresh]

remove obsolete "version" in docker compose

Enable anonymous auth admin login so no need to enter password

@Leon-Africa Leon-Africa requested review from a team and zivkovicmilos as code owners July 7, 2024 22:07
@Leon-Africa Leon-Africa requested review from sw360cab and removed request for a team July 7, 2024 22:07
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jul 7, 2024
@Leon-Africa Leon-Africa changed the title add pyroscope and updates compose feat: add pyroscope and updates compose Jul 7, 2024
@thehowl
Copy link
Member

thehowl commented Jul 10, 2024

cc @sw360cab

Not sure if this is something we want

@Leon-Africa
Copy link
Author

@thehowl To elabortate this makes local testing more feasible - the existing automation pulls from ghcr.io/gnolang/gno/gnoland which means its static. If you make a change to a .go file you will not have any immediate feedback on how that change/s affect the node.

By using the approach of a local build developers will be able to get immediate feedback on how their changes affect the node.

pyroscope is an additional add to that.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.14%. Comparing base (bd99fbe) to head (3c1c6d3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2536      +/-   ##
==========================================
- Coverage   60.16%   60.14%   -0.02%     
==========================================
  Files         561      561              
  Lines       74999    74999              
==========================================
- Hits        45120    45108      -12     
- Misses      26500    26511      +11     
- Partials     3379     3380       +1     
Flag Coverage Δ
contribs/gnodev 60.58% <ø> (-0.82%) ⬇️
contribs/gnofaucet 14.46% <ø> (ø)
tm2 62.02% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw360cab
Copy link
Contributor

This PR works on two different topics

  • It does solve some small defects (e.g. Dockerfiles and compose clenaups) which can be cool and apporved
  • It introduces out of nowhere Grafana Peryscope within the Gno codebase. I don't see the reason to create a tight dependency like that in the Gno codebase, moreover this is actually a tool we are neither using nor planning to use.

I will close this and be happy to review code that works on the previous aspects in separeted PRs.

@sw360cab sw360cab closed this Aug 13, 2024
@Leon-Africa
Copy link
Author

@sw360cab thanks for the feedback - will create separate pr as suggested and reference this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants